chore(tests): add linting to e2e tests #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
danilrwx
requested changes
Jul 14, 2025
tests/e2e/config/project.go
Outdated
| func PrepareProject(testData string) { | ||
| kustomization := fmt.Sprintf("%s/%s", testData, "kustomization.yaml") | ||
| ns, err := kustomize.GetNamespace(kustomization) | ||
| ns, _ := kustomize.GetNamespace(kustomization) |
Contributor
There was a problem hiding this comment.
It is better not to ignore the error handling, but to add it
tests/e2e/config/project.go
Outdated
| namePrefix, err := GetNamePrefix() | ||
| if err != nil { | ||
| } | ||
| namePrefix, _ := GetNamePrefix() |
Contributor
There was a problem hiding this comment.
It is better not to ignore the error handling, but to add it
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
Contributor
|
Workflow has started. The target step completed with status: success. |
danilrwx
previously approved these changes
Jul 15, 2025
nevermarine
force-pushed
the
chore/ci/add-linting-to-the-tests
branch
2 times, most recently
from
7a7e5e0 to
ae3edba
Compare
Signed-off-by: Maxim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
hardcoretime
approved these changes
Jul 16, 2025
universal-itengineer
approved these changes
Jul 16, 2025
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
* chore(tests): add linting to e2e tests Signed-off-by: Maksim Fedotov <[email protected]> * fix newline Signed-off-by: Maksim Fedotov <[email protected]> * fix name Signed-off-by: Maksim Fedotov <[email protected]> * remove prune path Signed-off-by: Maksim Fedotov <[email protected]> * fix e2e config Signed-off-by: Maksim Fedotov <[email protected]> * handle errors Signed-off-by: Maksim Fedotov <[email protected]> * update .golangci.yaml Signed-off-by: Maksim Fedotov <[email protected]> * fix updatedVmObj & updatedVmObjC Signed-off-by: Maksim Fedotov <[email protected]> * fix %s in fmt.Errorf Signed-off-by: Maksim Fedotov <[email protected]> * fix insecureTls Signed-off-by: Maksim Fedotov <[email protected]> * fix ApiVersion Signed-off-by: Maksim Fedotov <[email protected]> * fix VmConfiguration Signed-off-by: Maksim Fedotov <[email protected]> * fix Vm* variables Signed-off-by: Maksim Fedotov <[email protected]> * fix SshUser Signed-off-by: Maksim Fedotov <[email protected]> * fix SshOptions Signed-off-by: Maksim Fedotov <[email protected]> * fix VmConf Signed-off-by: Maksim Fedotov <[email protected]> * fix SshCommand Signed-off-by: Maksim Fedotov <[email protected]> * fix LocalSshOpts Signed-off-by: Maksim Fedotov <[email protected]> * fix VmLabelAnnotation & GetFullApiResourceName Signed-off-by: Maksim Fedotov <[email protected]> * golangci-lint run --fix Signed-off-by: Maksim Fedotov <[email protected]> * fix stylecheck dot imports error Signed-off-by: Maksim Fedotov <[email protected]> * disable all initials except VM and SSH Signed-off-by: Maksim Fedotov <[email protected]> * fix Vm->VM ST1003 errors by stylecheck Signed-off-by: Maksim Fedotov <[email protected]> * fix fmt.Errorf() formatting Signed-off-by: Maksim Fedotov <[email protected]> * replace other initialisms Signed-off-by: Maksim Fedotov <[email protected]> * golangci-lint --fix Signed-off-by: Maksim Fedotov <[email protected]> --------- Signed-off-by: Maksim Fedotov <[email protected]> Signed-off-by: Maxim Fedotov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add linting to e2e tests.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries